Skip to content

Conversation

@GulajavaMinistudio
Copy link

No description provided.

Tofandel and others added 30 commits November 12, 2024 15:57
PR-URL: #55602
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
PR-URL: #55819
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55810
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Notable changes:

esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333

PR-URL: #55768
Signed-off-by: Joe Bowbeer <[email protected]>
PR-URL: #55812
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #55820
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #55830
Refs: nodejs/changelog-maker#167
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55548
Fixes: #55538
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
There was some repetitive logics that validated the existence of
eventlisteners. We now replace this with a single line of,
`hasEventListener(self, type)`.
`self` is the object(e.g. EventEmitter) to be checked whether
eventlisteners exists or not.
`type` is the type of eventlisteners, which can be `undefined`

PR-URL: #55230
Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #49686
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Setting of UV_THREADPOOL_SIZE from inside process using
process.env.UV_THREADPOOL_SIZE is not guaranteed to work as
the thread pool would have been created as part of the runtime
initialisation much before user code is run.

update doc/api/cli.md

PR-URL: #55832
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55836
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55757
Refs: #55723
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
PR-URL: #55846
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55855
Refs: #55333
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #55856
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #55851
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
PR-URL: #55850
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This reverts commit 45c6a9e.

PR-URL: #55828
Fixes: #55826
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #55778
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Implements https://github.com/orgs/nodejs/discussions/41283#discussioncomment-11188239

PR-URL: #55778
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #55785
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Fixes #55849

PR-URL: #55858
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Remove files from watcher `dependencyOwners` on file change only if it
has no other owners.

Co-authored-by: Pietro Marchini <[email protected]>
PR-URL: #55565
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #51192
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #51192
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #55866
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Bumps [@eslint/plugin-kit](https://github.com/eslint/rewrite) from 0.2.0 to 0.2.3.
- [Release notes](https://github.com/eslint/rewrite/releases)
- [Changelog](https://github.com/eslint/rewrite/blob/main/release-please-config.json)
- [Commits](eslint/rewrite@core-v0.2.0...plugin-kit-v0.2.3)

---
updated-dependencies:
- dependency-name: "@eslint/plugin-kit"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #55875
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #54181
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@GulajavaMinistudio GulajavaMinistudio merged commit 2866fb3 into javascript-indonesias:master Nov 18, 2024
20 of 22 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.05556% with 43 lines in your changes missing coverage. Please review.

Project coverage is 87.92%. Comparing base (03d414e) to head (746b17e).
Report is 1068 commits behind head on master.

Files with missing lines Patch % Lines
src/node_sqlite.cc 90.82% 4 Missing and 16 partials ⚠️
src/string_bytes.cc 20.00% 8 Missing ⚠️
lib/fs.js 93.33% 3 Missing ⚠️
lib/internal/watch_mode/files_watcher.js 25.00% 3 Missing ⚠️
src/node_buffer.cc 80.00% 1 Missing and 2 partials ⚠️
src/node_report_utils.cc 89.28% 0 Missing and 3 partials ⚠️
src/node_sqlite.h 0.00% 2 Missing ⚠️
lib/internal/modules/package_json_reader.js 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   88.34%   87.92%   -0.42%     
==========================================
  Files         652      654       +2     
  Lines      187376   188036     +660     
  Branches    35999    35878     -121     
==========================================
- Hits       165530   165329     -201     
- Misses      15142    15878     +736     
- Partials     6704     6829     +125     
Files with missing lines Coverage Δ
lib/events.js 98.18% <100.00%> (-1.57%) ⬇️
lib/internal/crypto/hkdf.js 95.85% <100.00%> (+0.02%) ⬆️
lib/internal/crypto/pbkdf2.js 94.61% <100.00%> (-0.05%) ⬇️
lib/internal/fs/utils.js 94.99% <100.00%> (-4.71%) ⬇️
lib/internal/test_runner/mock/mock_timers.js 98.74% <100.00%> (+<0.01%) ⬆️
lib/internal/util/inspect.js 99.95% <100.00%> (+0.04%) ⬆️
src/inspector_js_api.cc 86.29% <100.00%> (+0.05%) ⬆️
src/node_report.cc 93.53% <100.00%> (+0.01%) ⬆️
src/node_report.h 100.00% <ø> (ø)
lib/internal/modules/package_json_reader.js 97.22% <83.33%> (-2.17%) ⬇️
... and 7 more

... and 106 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.